don't return a 'sparse' array from getMountsForFileId #41434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
ArtificialOwl,
Altahrim and
sorbaugh
and removed request for
a team
This was referenced Nov 14, 2023
Merged
Merged
Merged
|
Conflicts |
skjnldsv
added
2. developing
This was referenced Mar 18, 2024
Merged
Merged
Merged
Altahrim
approved these changes
Apr 30, 2024
skjnldsv
approved these changes
Apr 30, 2024
Merged
|
was fixed with #46886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all callers are setup to deal with non-continuous arrays here. Easier to fix it here than to verify all callers