Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(a11y): Focus on sharing quick permission radio #41560

Merged
merged 2 commits into from
Nov 17, 2023
Merged

fix(a11y): Focus on sharing quick permission radio #41560

merged 2 commits into from
Nov 17, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 17, 2023

Summary

  • Fix focus being returned to body

Checklist

@Pytal
fix(a11y): Focus on sharing quick permission radio
6329da9 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
4c126f2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews accessibility labels Nov 17, 2023
@Pytal Pytal added this to the Nextcloud 28 milestone Nov 17, 2023
@Pytal Pytal self-assigned this Nov 17, 2023
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works! Thank you!

@susnux susnux merged commit 8c24a32 into master Nov 17, 2023
42 checks passed
@susnux susnux deleted the fix/a11y/advanced-sharing-focus branch November 17, 2023 10:41
@blizzz blizzz mentioned this pull request Nov 20, 2023
Merged
5 tasks
@Fenn-CS Fenn-CS mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @susnux @JuliaKirschenheuter @Fenn-CS