Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable27] feat(LDAP): implement IIsAdmin interface #41813

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Nov 28, 2023

manual backport of #41650 – automatic not possible to due changes in Groups logic.

@Rello
Copy link
Contributor

Rello commented Nov 30, 2023

Confirmed working in 27.1.4; tested as patch in openDesk

@blizzz blizzz mentioned this pull request Dec 4, 2023
- add configuration to specify one LDAP group acting as admin group (CLI)
- implement `isAdmin()` method, basically relying on inGroup against the
  configured group

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz marked this pull request as ready for review December 5, 2023 12:57
@blizzz blizzz requested a review from come-nc as a code owner December 5, 2023 12:57
@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 5, 2023
@blizzz blizzz merged commit a4a120c into stable27 Dec 5, 2023
37 of 41 checks passed
@blizzz blizzz deleted the backport/41650/stable27 branch December 5, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants