Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] Improve share logic for enforced password & expiry date #41936

Merged
merged 3 commits into from
Nov 30, 2023
Merged

[stable27] Improve share logic for enforced password & expiry date #41936

merged 3 commits into from
Nov 30, 2023

Commits on Nov 30, 2023

  1. fix: Change scroll container for sharing details 

    In order to meet accessibility requirements we cannot use a sticky
footer that overlaps important interactable content. Therefore this
moves to a scroll container for the details which does not include the
action buttons at the bottom.

Larger indentation change in SharingDetailsTab was required to have a
wrapping container for the scroll area.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
    @juliusknorr @Fenn-CS
    juliusknorr authored and Fenn-CS committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    07437d0 View commit details
    Browse the repository at this point in the history

  2. fix(a11y): Focus on sharing quick permission radio 

    Signed-off-by: Christopher Ng <chrng8@gmail.com>
    @Pytal @Fenn-CS
    Pytal authored and Fenn-CS committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    bedcbb8 View commit details
    Browse the repository at this point in the history

  3. Improve share logic for enforced password & expiry date 

    * It's possible for the admin to enforce and expiry date after, some
 shares have been created. This commit makes possible to update the
 share with the new admin constraints.

* This commit would users to modify enforced expiry to anything within
 range and less than the enforced limit in the pre-create dialog for public
 shares.

* This commit fixes, unable to update share without updating password.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
    @Fenn-CS @nextcloud-command
    Fenn-CS authored and nextcloud-command committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    8c5ea73 View commit details
    Browse the repository at this point in the history