-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip outside click, should abort share creation #42126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
force-pushed
the
click-outside-should-abort-share
branch
from
December 8, 2023 17:07
c591790
to
98ee9d6
Compare
8 tasks
artonge
requested changes
Dec 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some files seem unrelated
It's unexpected that click outside a tooltip would proceed with the action that could be carried out inside the tooltip. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
click-outside-should-abort-share
branch
from
December 11, 2023 20:03
98ee9d6
to
41061dd
Compare
Debounce `onExpirationChange` to avoid calling `formatDateToString` on invalid on uncompletely inputed date strings. Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Fenn-CS
force-pushed
the
click-outside-should-abort-share
branch
from
December 11, 2023 20:06
41061dd
to
04e8733
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
artonge
approved these changes
Dec 11, 2023
susnux
approved these changes
Dec 12, 2023
/backport to stable28 |
/backport to stable27 |
/backport to stable28 |
/backport to stable27 |
1 task
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : #42046, #42114