Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore shared Collective mounts when scanning files #42497

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+4 −2
Open

Ignore shared Collective mounts when scanning files #42497

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7de651b
Ignore shared Collective mounts when scanning files
arnowelzel Dec 27, 2023
6c9178f
Update comment about ignoring collectives
arnowelzel Dec 27, 2023
dd52cc1
Merge branch 'nextcloud:master' into issue-42496
arnowelzel Feb 24, 2024
33365c6
Check ID instead of storage class
arnowelzel Feb 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/private/Files/Utils/Scanner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
use OC\ForbiddenException;
use OC\Hooks\PublicEmitter;
use OC\Lock\DBLockingProvider;
use OCA\Collectives\Mount\CollectiveStorage;
use OCA\Files_Sharing\SharedStorage;
use OCP\EventDispatcher\IEventDispatcher;
use OCP\Files\Events\BeforeFileScannedEvent;
Expand Down Expand Up @@ -238,10 +239,11 @@ public function scan($dir = '', $recursive = \OC\Files\Cache\Scanner::SCAN_RECUR
}
}

// don't scan received local shares, these can be scanned when scanning the owner's storage
if ($storage->instanceOfStorage(SharedStorage::class)) {
// don't scan received local shares or collectives, these can be scanned when scanning the owner's storage
if (substr($storage->getId(), 0, 6) !== 'home::') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break scanning of external storages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What ID do external storages have?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they all have different prefixes, in general attempts to filter by storage id is imprecise at best.

continue;
}

$relativePath = $mount->getInternalPath($dir);
$scanner = $storage->getScanner();
$scanner->setUseTransactions(false);
Expand Down
Loading