Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate avatars for display name with chinese characters #42534

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Dec 30, 2023

Summary

We are using NotoSans-Regular for generating avatars.

If the character is not supported by NotoSans-Regular the users end up with an avatar like below:

image

The pull request here adds another font and uses a poor regex to flip out the font when chinese characters are detected. The font actually should cover even more characters.

@danxuliu did a deep dive into the topic a while ago and wrote down everything you need to know: #25529

TODO

  • Testing Testing
  • Do we want to ship another font
  • Extend regex to match supported characters for NotoSC font

Checklist

@kesselb kesselb added this to the Nextcloud 29 milestone Dec 30, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@AndyScherzinger AndyScherzinger force-pushed the enh/noid/avatar-chinese branch from 43758ee to 16bf72a Compare May 23, 2024 05:44
@AndyScherzinger
Copy link
Member

@kesselb can you tell a bit about the state of the PR? 😊

@kesselb
Copy link
Contributor Author

kesselb commented May 23, 2024

@AndyScherzinger Added some context to the pull request.

I never got feedback in the forums if the suggested patch works, and therefore did not continue.

This font topic is a rather complicated one, and I have no idea if that's a sane approach.

This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv skjnldsv marked this pull request as draft November 15, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants