-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(settings): removed background-gradient to ensure contrast ratio a11y requirements #42570
enh(settings): removed background-gradient to ensure contrast ratio a11y requirements #42570
Conversation
…11y requirements Signed-off-by: Eduardo Morales <emoral435@gmail.com>
/backport to stable28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Looks good, additionally: we don't use #000000
for text, we only use #222222
, so that should be the color of the text and the color that the contrast is checked against :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Extra SS to check a random colors color contrast ratio
we don't need to pay attention on it, please test everything only on default background without changing color. We certificate only default background and everything else is not relevant for us ;)
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
☑️ Resolves #42440
🖼️ Screenshots
Extra SS to check a random colors color contrast ratio
🚧 Summary
Removed the background gradient on the profile preview section of the settings to increase accessibility
Checklist