Migrate cron setup checks to new API #42802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
come-nc
changed the title
come-nc
requested review from
nickvergessen,
susnux,
a team,
ArtificialOwl,
icewind1991 and
blizzz
and removed request for
a team
nickvergessen
approved these changes
Jan 15, 2024
blizzz
approved these changes
Jan 15, 2024
come-nc
force-pushed
the
enh/migrate-overwritecliurl-setupcheck
branch
from
94ee5b5 to
0483064
Compare
Base automatically changed from
enh/migrate-overwritecliurl-setupcheck
to
master
January 16, 2024 09:47
come-nc
force-pushed
the
enh/migrate-cron-setupcheck
branch
from
dae6f3a to
34c77ac
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
enh/migrate-cron-setupcheck
branch
from
34c77ac to
9bdad44
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| public function run(): SetupResult { | ||
| $errors = json_decode($this->config->getAppValue('core', 'cronErrors', ''), true); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
| } | ||
|
|
||
| public function run(): SetupResult { | ||
| $lastCronRun = (int)$this->config->getAppValue('core', 'lastcron', '0'); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #41364
Summary
Migrate setup checks for cron job errors and last run timestamp. Initially intended to merge them into one check but not sure how to prioritize between errors and too old run?
Checklist