Add command to list mounts for user #42817
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
requested review from
a team,
ArtificialOwl,
blizzz and
nfebe
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Psalm found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
blizzz
approved these changes
Jan 16, 2024
blizzz
requested changes
Jan 16, 2024
| namespace OCP\Files\Storage; | ||
|
|
||
| interface IStorageDebugInfo { | ||
| /** |
| * | ||
| * @return string | ||
| */ | ||
| function debugInfo(): string; |
| return null; | ||
| default: | ||
| return "Unknown (" . $share->getShareType() . ")"; | ||
| if ($storage->instanceOfStorage(IStorageDebugInfo::class)) { |
There was a problem hiding this comment.
technically the complaint is right, the interface is not an IStorage. Does instance of not work here? Or method_exists in worst case?
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
skjnldsv
added
2. developing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be useful when debugging filesystem issues.
Includes a new extention interface to provide a debug description of storages instead of the previous hard coding of a few mounts in the
info:filecommand.