Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CI): MySQL unit tests, use LTS for code coverage and drop EOL #43170

Merged
merged 1 commit into from
Jan 31, 2024
Merged

fix(CI): MySQL unit tests, use LTS for code coverage and drop EOL #43170

merged 1 commit into from
Jan 31, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Jan 27, 2024

Summary

  1. Use the LTS version of MySQL for the code coverage instead of an EOL version
  2. Test LTS (8.0) and the latest version (8.3) (lower + upper bound) and drop EOL version 8.1

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Jan 27, 2024
@susnux susnux added this to the Nextcloud 29 milestone Jan 27, 2024
nickvergessen
nickvergessen previously requested changes Jan 29, 2024
View reviewed changes
.github/workflows/phpunit-mysql.yml Outdated Show resolved Hide resolved
@susnux @nickvergessen
fix(CI): MySQL unit tests, use LTS for code coverage and drop EOL
fc628fc 
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested a review from nickvergessen January 29, 2024 12:27
@susnux susnux dismissed nickvergessen’s stale review January 30, 2024 19:38

Changes implemented, please re-review

@nickvergessen nickvergessen merged commit 95ebc58 into master Jan 31, 2024
139 checks passed
@nickvergessen nickvergessen deleted the fix/mysql-ci branch January 31, 2024 16:06
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @nickvergessen @skjnldsv