Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IAppConfig] returns non lazy value while searching for lazy one #43247

Merged
merged 1 commit into from
Feb 6, 2024
Merged

[IAppConfig] returns non lazy value while searching for lazy one #43247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/private/AppConfig.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,11 +462,14 @@ private function getTypedValue(
throw new AppConfigTypeConflictException('conflict with value type from database');
}

if ($lazy) {
return $this->lazyCache[$app][$key] ?? $default;
}

return $this->fastCache[$app][$key] ?? $default;
/**
* - the pair $app/$key cannot exist in both array,
* - we should still returns an existing non-lazy value even if current method
* is called with $lazy is true
*
* This way, lazyCache will be empty until the load for lazy config value is requested.
*/
return $this->lazyCache[$app][$key] ?? $this->fastCache[$app][$key] ?? $default;
}

/**
Expand Down
Loading