-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(users): send welcome email when using occ #43250
Conversation
Signed-off-by: Philip Gatzka <philip.gatzka@mailbox.org>
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
Changed target to master to see the whole diff, my comment on original PR still applies:
-> This you fixed, I think
-> This you did not, if I’m not sure what the correct behavior is here, maybe simply add an other option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
Yeah it would be better to set a generated password when explicitly asked rather than implicitly based on other options. dropped password printing commit and pushed the requested changes in |
merged here: #40726 |
Enhance PR #40726
occ
. #25319Summary
This PR tries to solve the remaining issues in #40726
Specifically from the comment #40726 (review)
Checklist