Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rel attribute for fediverse link to make verification possible. #43364

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Schnoop
Copy link

@Schnoop Schnoop commented Feb 5, 2024

Summary

Add the rel attribute to make the mastodon verification possible

Checklist

Signed-off-by: Thorsten Daners <thorsten@daners.info>
@Schnoop Schnoop changed the title Add rel attribute for ferdiverse link to make verification possible. Add rel attribute for fediverse link to make verification possible. Feb 5, 2024
@come-nc come-nc requested review from Pytal and susnux February 19, 2024 16:46
@come-nc come-nc added the 3. to review Waiting for reviews label Feb 19, 2024
@come-nc come-nc added this to the Nextcloud 29 milestone Feb 19, 2024
@@ -68,7 +68,8 @@
class="user-actions__primary"
:href="primaryAction.target"
:icon="primaryAction.icon"
:target="primaryAction.id === 'phone' ? '_self' :'_blank'">
:target="primaryAction.id === 'phone' ? '_self' :'_blank'"
:rel="primaryAction.id === 'fediverse' ? 'me': null">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:rel="primaryAction.id === 'fediverse' ? 'me': null">
:rel="primaryAction.id === 'fediverse' ? 'me': undefined">

I think this makes it more clear and we use it like this on other places

@susnux
Copy link
Contributor

susnux commented Feb 20, 2024

/compile amend rebase

@susnux
Copy link
Contributor

susnux commented Feb 20, 2024

@Schnoop please rebase and recompile :)

This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress enhancement stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make mastodon verification work with public link on profile page
5 participants