perf(sharing): Improve performance of share provider queries #43481
+495
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an be used Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
First of all the method was huge and was handling multiple usecases: - User and group shares - "get all" (mount logic) and "get some" To improve the performance of the "get all" it was extracted into yet another method, to allow to further optimize it. E.g. the query was split into reading the shares and reading the filecache, which will be required for future work with sharding anyway. Without limits we also don't need to sort the entries. Signed-off-by: Joas Schilling <coding@schilljs.com>
…e type+with Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
enhancement
3. to review
Signed-off-by: Joas Schilling <coding@schilljs.com>
skjnldsv
added
2. developing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Split the getSharedWith() method
To improve the performance of the "get all" it was extracted into
yet another method, to allow to further optimize it.
E.g. the query was split into reading the shares and reading the
filecache, which will be required for future work with sharding anyway.
Without limits we also don't need to sort the entries.
Checklist