Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Right click menu offset and list scrolled glitch #44139

Merged
merged 4 commits into from
Mar 13, 2024
Merged

fix(files): Right click menu offset and list scrolled glitch #44139

merged 4 commits into from
Mar 13, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Mar 11, 2024 •
edited
Loading

Summary

Before After
image image

Checklist

@Pytal Pytal added this to the Nextcloud 29 milestone Mar 11, 2024
@Pytal Pytal self-assigned this Mar 11, 2024
@Pytal Pytal requested a review from skjnldsv as a code owner March 11, 2024 23:28
@Pytal
Copy link
Member Author

Pytal commented Mar 11, 2024

/backport to stable28

@Pytal Pytal enabled auto-merge March 11, 2024 23:29
@SystemKeeper

This comment was marked as resolved.

Sign in to view
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Merged
@Pytal
fix(files): Right click menu scroll reset glitch
26bbb8c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/right-click-files-list branch from 4c5a5aa to 3c4048d Compare March 12, 2024 19:19
@Pytal

This comment was marked as resolved.

Sign in to view
@SystemKeeper
Copy link
Contributor

Much better now! Only thing I noticed is an offset issue when the menu opens to the top:

Bildschirmaufnahme.2024-03-12.um.22.03.05.mov

Pytal added 3 commits March 12, 2024 14:59
@Pytal
fix(files): Right click menu positioning
742e5b6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: compile assets
c7fc4b1 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
fix(cypress): ResizeObserver loop undelivered notifications error
84ceadd 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the fix/right-click-files-list branch from 3c4048d to 84ceadd Compare March 12, 2024 22:01
@Pytal Pytal requested a review from sorbaugh March 12, 2024 22:38
SystemKeeper
SystemKeeper approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@SystemKeeper SystemKeeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, works fine in the tested scenarios. A small mis-alignment can still happen if the menu is rerendered with less items than before, but nothing to adjust for this PR.

@Pytal Pytal merged commit 463a68f into master Mar 13, 2024
98 checks passed
@Pytal Pytal deleted the fix/right-click-files-list branch March 13, 2024 08:49
@backportbot backportbot bot mentioned this pull request Mar 13, 2024
Merged
3 tasks
@susnux susnux mentioned this pull request Mar 13, 2024
Closed
@Altahrim Altahrim mentioned this pull request Mar 14, 2024
Merged
@Pytal Pytal mentioned this pull request Apr 2, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@artonge artonge Awaiting requested review from artonge

@szaimen szaimen Awaiting requested review from szaimen

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 29
3 participants
@Pytal @SystemKeeper @skjnldsv