Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Navigation): ensure NavManager is inited when adding an entry #44178

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Mar 13, 2024

Summary

otherwise custom order cannot be applied

Needed by nextcloud/tables#904

Checklist

otherwise custom order cannot be applied

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@Pytal
Copy link
Member

Pytal commented Mar 13, 2024

Would adding as a closure entry be better? ref: 9708466

@blizzz
Copy link
Member Author

blizzz commented Mar 13, 2024

Would adding as a closure entry be better? ref: 9708466

Ah, probably, but it does not make this fix less useful.

Even better would be an Event one could listen to. Right now I react to BeforeTemplateRenderedEvent, but it does only feel so right.

@Pytal
Copy link
Member

Pytal commented Mar 13, 2024

Ah, probably, but it does not make this fix less useful.

Agreed!

Even better would be an Event one could listen to. Right now I react to BeforeTemplateRenderedEvent, but it does only feel so right.

👍

@blizzz
Copy link
Member Author

blizzz commented Mar 13, 2024

☑️ Changed my code to supply a Closure – thanks!

@blizzz blizzz merged commit 10593d1 into master Mar 14, 2024
160 checks passed
@blizzz blizzz deleted the fix/noid/nav-init-add branch March 14, 2024 08:26
@Altahrim Altahrim mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants