Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] fix: No password set for new mail shares #44193

Merged
merged 2 commits into from
Mar 15, 2024
Merged

[stable27] fix: No password set for new mail shares #44193

merged 2 commits into from
Mar 15, 2024

Commits on Mar 14, 2024

  1. fix: No password set for new mail shares 

    Before the password is set on a new share, the computed property `hasUnsavedPassword`
is used to check that `this.share.newPassword` is not undefined. Direct assignment without
using Vue's `this.$set` makes it impossible for vue to detect that changes have happened on the share
object. Hence the inreactivity.
This worked initially most likely because `this.share.newPassword = await GeneratePassword()` was executed
before the computed properties where evaluated.
Resolves : #43919

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
    @Fenn-CS @susnux
    Fenn-CS authored and susnux committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    5606469 View commit details
    Browse the repository at this point in the history

  2. chore(assets): Recompile assets 

    Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
    @nextcloud-command
    nextcloud-command committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8699d16 View commit details
    Browse the repository at this point in the history