-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files_external): Remove invalid jQuery Tooltip usage #44264
Conversation
This caused the UI to throw an error causing it to be unusable. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI is working again with this PR.
Only problem I’ve spotted: clicking the 3-dot button opens a menu, but clicking it again does not close it, the user have to find a spot in the UI that does nothing and click it, it’s the only way to close this menu.
Actually not sure if 28 is impacted or not, @susnux ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested and seems to work :)
No stable 28 was not affected, we only did this for 29 iirc. |
Unrelated, those should not cause problems. The 3-dot menu is another issue. I hope to find time to migrate the settings to vue soon 😉 |
Summary
The tooltip methods were remove long ago but we removed the "polyfill" (try-catch) so this caused the UI to throw an error causing it to be unusable.
Checklist