Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_external): Remove invalid jQuery Tooltip usage #44264

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 18, 2024

Summary

The tooltip methods were remove long ago but we removed the "polyfill" (try-catch) so this caused the UI to throw an error causing it to be unusable.

Checklist

This caused the UI to throw an error causing it to be unusable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 29 milestone Mar 18, 2024
@susnux susnux requested review from come-nc, a team, Pytal, szaimen and emoral435 and removed request for a team March 18, 2024 00:26
@come-nc
Copy link
Contributor

come-nc commented Mar 18, 2024

@susnux
And what about those:

> grep '.tooltip(' -R core
core/src/systemtags/systemtagsinputfield.js:                            $renameForm.find('[title]').tooltip({
core/src/systemtags/systemtagsinputfield.js:                            $(ev.target).tooltip('option', 'hide')
core/src/systemtags/systemtagsinputfield.js:                            this.$el.find('[title]').tooltip({ placement: 'bottom' })
core/js/backgroundjobs.js:      $('.section .icon-info').tooltip({

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI is working again with this PR.
Only problem I’ve spotted: clicking the 3-dot button opens a menu, but clicking it again does not close it, the user have to find a spot in the UI that does nothing and click it, it’s the only way to close this menu.

@come-nc
Copy link
Contributor

come-nc commented Mar 18, 2024

/backport to stable28

Actually not sure if 28 is impacted or not, @susnux ?

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and seems to work :)

@susnux
Copy link
Contributor Author

susnux commented Mar 18, 2024

Actually not sure if 28 is impacted or not?

No stable 28 was not affected, we only did this for 29 iirc.

@nextcloud nextcloud deleted a comment from come-nc Mar 18, 2024
@susnux
Copy link
Contributor Author

susnux commented Mar 18, 2024

And what about those:

Unrelated, those should not cause problems. The 3-dot menu is another issue. I hope to find time to migrate the settings to vue soon 😉

@susnux susnux merged commit 4de045a into master Mar 18, 2024
123 checks passed
@susnux susnux deleted the fix/remove-old-unsupported-tooltip-dispose branch March 18, 2024 12:45
@Altahrim Altahrim mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Impossible to add an external storage in 29
3 participants