Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(settings): Ensure media for app discover section is scaled correctly #44286

Merged
merged 3 commits into from
Mar 19, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Mar 18, 2024

Summary

The image is a bit bad choosen, but you get the point (it should not clip like that):

before after
Screenshot 2024-03-18 at 18-57-35 Discover - App Store - Nextcloud Screenshot 2024-03-18 at 18-59-11 Discover - App Store - Nextcloud

Checklist

@susnux susnux added this to the Nextcloud 29 milestone Mar 18, 2024
@susnux susnux requested review from a team, Pytal, szaimen and emoral435 and removed request for a team March 18, 2024 18:11
@susnux susnux mentioned this pull request Mar 18, 2024
@Pytal

This comment was marked as resolved.

@susnux

This comment was marked as resolved.

Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks nice!

susnux added 3 commits March 19, 2024 19:42
…be fetched

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/app-discover-media-size branch from 5edaf15 to d71e693 Compare March 19, 2024 18:44
@AndyScherzinger AndyScherzinger merged commit 83746f7 into master Mar 19, 2024
104 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/app-discover-media-size branch March 19, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants