-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable26] Forbid tagging readonly files #44308
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@@ -60,10 +61,19 @@ | |||
$tagMapper, | |||
$userSession, | |||
$groupManager, | |||
function ($name) { | |||
function ($name): bool { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
$nodes = \OC::$server->getUserFolder()->getById((int)$name); | ||
return !empty($nodes); | ||
} | ||
}, | ||
function ($name): bool { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
} | ||
}, | ||
function ($name): bool { | ||
$nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
} | ||
}, | ||
function ($name): bool { | ||
$nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
@@ -77,7 +87,8 @@ | |||
$tagMapper, | |||
$userSession, | |||
$groupManager, | |||
$entityExistsFunction | |||
$entityExistsFunction, | |||
fn ($name) => true, |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
CI failure not related |
Backport of PR #44299 (originally #44297)