Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] Forbid tagging readonly files #44308

Merged
merged 3 commits into from
Mar 21, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 19, 2024

Backport of PR #44299 (originally #44297)

come-nc added 3 commits March 19, 2024 10:57
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@backportbot backportbot bot added the 3. to review Waiting for reviews label Mar 19, 2024
@backportbot backportbot bot added this to the Nextcloud 26.0.13 milestone Mar 19, 2024
@@ -60,10 +61,19 @@
$tagMapper,
$userSession,
$groupManager,
function ($name) {
function ($name): bool {

Check notice

Code scanning / Psalm

MissingClosureParamType Note

Parameter $name has no provided type
$nodes = \OC::$server->getUserFolder()->getById((int)$name);
return !empty($nodes);
}
},
function ($name): bool {

Check notice

Code scanning / Psalm

MissingClosureParamType Note

Parameter $name has no provided type
}
},
function ($name): bool {
$nodes = \OC::$server->getUserFolder()->getById((int)$name);

Check notice

Code scanning / Psalm

DeprecatedMethod Note

The method OC\Server::getUserFolder has been marked as deprecated
}
},
function ($name): bool {
$nodes = \OC::$server->getUserFolder()->getById((int)$name);

Check notice

Code scanning / Psalm

PossiblyNullReference Note

Cannot call method getById on possibly null value
@@ -77,7 +87,8 @@
$tagMapper,
$userSession,
$groupManager,
$entityExistsFunction
$entityExistsFunction,
fn ($name) => true,

Check notice

Code scanning / Psalm

MissingClosureParamType Note

Parameter $name has no provided type
@come-nc come-nc changed the title [stable26] [stable27] Forbid tagging readonly files [stable26] Forbid tagging readonly files Mar 19, 2024
@come-nc come-nc self-assigned this Mar 19, 2024
@Altahrim Altahrim mentioned this pull request Mar 21, 2024
7 tasks
@come-nc come-nc added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 21, 2024
@come-nc
Copy link
Contributor

come-nc commented Mar 21, 2024

CI failure not related

@nickvergessen nickvergessen merged commit 4c6d0ea into stable26 Mar 21, 2024
36 of 37 checks passed
@nickvergessen nickvergessen deleted the backport/44299/stable26 branch March 21, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants