[stable24] Forbid tagging readonly files #44324
Conversation
![backportbot[bot]](https://avatars.githubusercontent.com/in/60201?s=60&v=4){kind=small}
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
25 supports 7.4 Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -60,10 +60,19 @@ | |||
| $tagMapper, | |||
| $userSession, | |||
| $groupManager, | |||
| function ($name) { | |||
| function ($name): bool { | |||
Check notice
Code scanning / Psalm
MissingClosureParamType Note
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); | ||
| return !empty($nodes); | ||
| } | ||
| }, | ||
| function ($name): bool { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
| } | ||
| }, | ||
| function ($name): bool { | ||
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
DeprecatedMethod Note
| } | ||
| }, | ||
| function ($name): bool { | ||
| $nodes = \OC::$server->getUserFolder()->getById((int)$name); |
Check notice
Code scanning / Psalm
PossiblyNullReference Note
| @@ -77,7 +86,8 @@ | |||
| $tagMapper, | |||
| $userSession, | |||
| $groupManager, | |||
| $entityExistsFunction | |||
| $entityExistsFunction, | |||
| fn ($name) => true, | |||
Check notice
Code scanning / Psalm
MissingClosureParamType Note
come-nc
requested review from
Altahrim,
a team,
ArtificialOwl and
nfebe
and removed request for
a team
Backport of PR #44309 / #44297