-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dav): adjust usages of webdav.customRequest #44344
Conversation
/backport to stable28 |
Is it broken in 28? 🤔 |
It's not so we can skip the backport for now. Although it was fixed for >= 27 in other places last year: a66cae0 |
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
72d3f4b
to
e727a3b
Compare
There is still the issue on 28.0.9, as I can see in https://github.com/nextcloud/server/blob/v28.0.9/apps/dav/src/service/CalendarService.js the line 61 wasn't change with this PR. When do you think this would be done ? |
/backport to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/44344/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick e727a3b0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44344/stable28 Error: Failed to clone repository: Failed to checkout branches: Updating 1cc7851..ab511e8
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Webdav is not using axios any more so we have to await a response's body ourselves.
Checklist