Responsive app menu

[juliusknorr]

As discussed at the hackweek with @jancborchardt

ToDo:

• Fix loading icon
• Enabling/disabling apps doesn't show up nicely

[icewind1991]

This manages to break the file list for me, it doesn't show any files in the list

[jancborchardt]

Can confirm @icewind1991's issue. It also results in a double scrollbar on the right in Firefox, and there are too few items shown by default (should be 8 icons).

(Screenshot is after scrolling, so the files are visible – shows double scrollbar and too few icons.)

cc @juliushaertl

[codecov]

Codecov Report

Merging #4439 into master will increase coverage by 0.19%.
The diff coverage is 27.69%.

@@             Coverage Diff              @@
##             master    #4439      +/-   ##
============================================
+ Coverage      53.9%   54.09%   +0.19%     
+ Complexity    21701    21695       -6     
============================================
  Files          1272     1331      +59     
  Lines         75815    83079    +7264     
  Branches          0     1315    +1315     
============================================
+ Hits          40870    44944    +4074     
- Misses        34945    38135    +3190

Impacted Files	Coverage Δ	Complexity Δ
lib/private/legacy/app.php	53.4% <ø> (+3.4%)	222 <0> (-6)	⬇️
lib/private/TemplateLayout.php	0% <ø> (ø)	35 <0> (ø)	⬇️
settings/js/apps.js	27.47% <0%> (ø)	0 <0> (?)
core/templates/layout.user.php	0% <0%> (ø)	0 <0> (ø)	⬇️
core/js/js.js	61.69% <46.15%> (ø)	0 <0> (?)
apps/comments/lib/EventHandler.php	79.16% <0%> (-8.34%)	7% <0%> (ø)
lib/private/User/Manager.php	83.81% <0%> (-0.58%)	68% <0%> (ø)
apps/files_sharing/js/public.js	47.91% <0%> (ø)	0% <0%> (?)
core/js/oc-requesttoken.js	100% <0%> (ø)	0% <0%> (?)
core/js/files/client.js	87.62% <0%> (ø)	0% <0%> (?)
... and 58 more

Fixed

[juliusknorr]

Ready for review @nextcloud/designers

[juliusknorr]

@icewind1991 Thanks for having a look. Should be fixed now, there was some leftover css rule from development. 🙈

[MorrisJobke]

Tested and works (even in Edge ;)) 👍

[skjnldsv]

Do we still need those ugly/strange opacity filters for ie?

[skjnldsv]

Incredible work! :)

[jancborchardt]

Works great now! 👍

[jancborchardt]

Awesome work @juliushaertl! This is so cool :)

@MorrisJobke @LukasReschke @rullzer what do we do about the codecov patch diff?

[LukasReschke]

@MorrisJobke @LukasReschke @rullzer what do we do about the codecov patch diff?

Ideally in a world where everything is awesome: Add tests for this 😉

/me hides 😉

[LukasReschke]

… as that isn't the case => merged 😉