Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Serve well-known assetlinks json #44665

Closed
wants to merge 1 commit into from
Closed

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 4, 2024

Summary

Checklist

@Pytal Pytal added this to the Nextcloud 30 milestone Apr 4, 2024
@Pytal Pytal requested a review from alperozturk96 April 4, 2024 23:49
@Pytal Pytal self-assigned this Apr 4, 2024
@Pytal Pytal requested a review from artonge April 4, 2024 23:50
@Pytal
Copy link
Member Author

Pytal commented Apr 4, 2024

cc @alperozturk96 feel free to edit the assetlinks.json in the second commit

@alperozturk96
Copy link

cc @alperozturk96 feel free to edit the assetlinks.json in the second commit

We need to put "sha256_cert_fingerprints" please don't merge, until we put it. @tobiasKaminsky Can you edit assetlinks.json?

@kesselb
Copy link
Contributor

kesselb commented Apr 5, 2024

package_name and sha256_cert_fingerprints should be configurable via config.php similar to https://github.com/nextcloud/server/blob/master/config/config.sample.php#L1105-L1123 for branded clients.

@Pytal
Copy link
Member Author

Pytal commented Apr 6, 2024

package_name and sha256_cert_fingerprints should be configurable via config.php similar to master/config/config.sample.php#L1105-L1123 for branded clients.

Makes sense 👍

Would we need to allow multiple package_name and sha256_cert_fingerprints @tobiasKaminsky?

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/assetlinks-json branch from fe602b1 to 247f653 Compare April 9, 2024 18:01
@Pytal Pytal requested a review from tobiasKaminsky April 9, 2024 18:02
@Pytal Pytal enabled auto-merge April 9, 2024 18:02
@tobiasKaminsky
Copy link
Member

Would we need to allow multiple package_name and sha256_cert_fingerprints @tobiasKaminsky?

@alperozturk96 can you check if this is possible or needed?

@alperozturk96
Copy link

alperozturk96 commented Apr 15, 2024

@Pytal assetlinks-json can contain multiple package names. @tobiasKaminsky as far as I can see we only have "com.nextcloud.client" this package name. Shouldn't be needed for another one.

Example

@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
@joshtrichards joshtrichards added the pending documentation This pull request needs an associated documentation update label Aug 2, 2024
This was referenced Aug 5, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
@Pytal Pytal closed this Aug 27, 2024
auto-merge was automatically disabled August 27, 2024 22:54

Pull request was closed

@Pytal Pytal deleted the feat/assetlinks-json branch August 27, 2024 22:54
@AndyScherzinger AndyScherzinger removed this from the Nextcloud 31 milestone Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress client: 🤖🍏 mobile enhancement pending documentation This pull request needs an associated documentation update stale Ticket or PR with no recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Associating website with Android app For Better DeepLink Support
7 participants