Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11] Prevent PHP request to get killed when using fclose callback (#26775) #4491

Merged
merged 1 commit into from
Apr 25, 2017

Conversation

icewind1991
Copy link
Member

Backport of #3157

  • Prevent PHP request to get killed when using fclose callback

  • Add ignore_user_abort everywhere where the time limit is set to 0

* Prevent PHP request to get killed when using fclose callback

* Add ignore_user_abort everywhere where the time limit is set to 0

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Apr 25, 2017
@icewind1991 icewind1991 added this to the Nextcloud 11.0.4 milestone Apr 25, 2017
@mention-bot
Copy link

@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @nickvergessen and @schiessle to be potential reviewers.

@codecov
Copy link

codecov bot commented Apr 25, 2017

Codecov Report

Merging #4491 into stable11 will decrease coverage by 0.05%.
The diff coverage is 25%.

@@              Coverage Diff              @@
##             stable11   #4491      +/-   ##
=============================================
- Coverage       57.46%   57.4%   -0.06%     
  Complexity      19441   19441              
=============================================
  Files            1157    1214      +57     
  Lines           65750   72573    +6823     
  Branches            0    1237    +1237     
=============================================
+ Hits            37782   41660    +3878     
- Misses          27968   30913    +2945
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/files.php 14.84% <0%> (-0.07%) 71 <0> (ø)
apps/dav/appinfo/v2/remote.php 0% <0%> (ø) 0 <0> (ø) ⬇️
apps/dav/appinfo/v1/webdav.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Files/View.php 85.69% <100%> (+0.01%) 367 <0> (ø) ⬇️
core/js/sharedialoglinkshareview.js 62.5% <0%> (ø) 0% <0%> (?)
apps/systemtags/js/systemtagsfilelist.js 73.04% <0%> (ø) 0% <0%> (?)
core/js/config.js 6.66% <0%> (ø) 0% <0%> (?)
core/js/sharedialogview.js 79.62% <0%> (ø) 0% <0%> (?)
apps/files_sharing/js/sharebreadcrumbview.js 97.36% <0%> (ø) 0% <0%> (?)
core/js/octemplate.js 11.11% <0%> (ø) 0% <0%> (?)
... and 52 more

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants