-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactors theming app - part 1 #45135
base: master
Are you sure you want to change the base?
Conversation
f9a5cae
to
64d68b9
Compare
64d68b9
to
9d7ba80
Compare
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
…promotion feature. Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
9d7ba80
to
85c1e13
Compare
hi, I've asked my colleagues who would be the best reviewer for this one! |
Hello @DaphneMuller, Thank you for your message! I have 50 PRs merged in, and I know eventually, someone will come, and we'll make it somehow. However, from a broader perspective, I wanted to share some thoughts on how you could encourage more people to contribute to the ecosystem. |
@fsamapoor I'll contact you by mail to continue that discussion 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good but might as well treat $l10n
the same as the others.
IConfig $config, | ||
ThemingDefaults $themingDefaults, | ||
private IConfig $config, | ||
private ThemingDefaults $themingDefaults, | ||
IL10N $l, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IL10N $l, | |
private IL10N $l10n, |
Summary
Following previous PRs taking advantage of PHP8's constructor property promotion, I have also made the required adjustments to the classes in the
theming
app.I decided to split the changes into multiple PRs to make reviewing the changes easier.
The improvements in this PR include:
Checklist