Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors theming app - part 1 #45135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fsamapoor
Copy link
Member

Summary

Following previous PRs taking advantage of PHP8's constructor property promotion, I have also made the required adjustments to the classes in the theming app.

I decided to split the changes into multiple PRs to make reviewing the changes easier.

The improvements in this PR include:

  • Using PHP8's constructor property promotion
  • Adding return types
  • Removing redundant docblocks
  • Replacing magic numbers with readable constants

Checklist

@fsamapoor fsamapoor force-pushed the refactor_theming_app_part1 branch from f9a5cae to 64d68b9 Compare May 1, 2024 06:37
@fsamapoor fsamapoor added 3. to review Waiting for reviews technical debt labels May 1, 2024
@fsamapoor fsamapoor requested review from a team, ArtificialOwl, icewind1991 and yemkareems and removed request for a team May 1, 2024 06:59
@joshtrichards joshtrichards force-pushed the refactor_theming_app_part1 branch from 64d68b9 to 9d7ba80 Compare May 10, 2024 14:01
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

…promotion feature.

Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
@fsamapoor fsamapoor force-pushed the refactor_theming_app_part1 branch from 9d7ba80 to 85c1e13 Compare May 17, 2024 07:01
@DaphneMuller
Copy link

hi, I've asked my colleagues who would be the best reviewer for this one!

@fsamapoor
Copy link
Member Author

hi, I've asked my colleagues who would be the best reviewer for this one!

Hello @DaphneMuller,

Thank you for your message!

I have 50 PRs merged in, and I know eventually, someone will come, and we'll make it somehow. However, from a broader perspective, I wanted to share some thoughts on how you could encourage more people to contribute to the ecosystem.

@DaphneMuller
Copy link

@fsamapoor I'll contact you by mail to continue that discussion 😊

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good but might as well treat $l10n the same as the others.

IConfig $config,
ThemingDefaults $themingDefaults,
private IConfig $config,
private ThemingDefaults $themingDefaults,
IL10N $l,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
IL10N $l,
private IL10N $l10n,

@joshtrichards joshtrichards added this to the Nextcloud 30 milestone May 26, 2024
This was referenced Jul 30, 2024
@Altahrim Altahrim mentioned this pull request Aug 5, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Aug 6, 2024
@Altahrim Altahrim mentioned this pull request Aug 7, 2024
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
@skjnldsv skjnldsv modified the milestones: Nextcloud 30, Nextcloud 31 Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants