Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry smb notify test a few times #45138

Merged
merged 1 commit into from
May 2, 2024
Merged

retry smb notify test a few times #45138

merged 1 commit into from
May 2, 2024

Conversation

icewind1991
Copy link
Member

I'm out of ideas on how to make the test more reliable so instead just give it 5 attempts.

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the smb-notify-test-retry branch from 9e5d529 to 13fe1e2 Compare May 1, 2024 15:28
@icewind1991 icewind1991 marked this pull request as ready for review May 1, 2024 16:04
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, yemkareems and sorbaugh and removed request for a team May 1, 2024 16:04
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label May 1, 2024
@icewind1991 icewind1991 added this to the Nextcloud 30 milestone May 1, 2024
@icewind1991
Copy link
Member Author

re-ran the tests a few times and it seems to be reliable enough now

@icewind1991
Copy link
Member Author

/backport to stable29

@icewind1991
Copy link
Member Author

/backport to stable28

@skjnldsv skjnldsv merged commit f883d80 into master May 2, 2024
163 checks passed
@skjnldsv skjnldsv deleted the smb-notify-test-retry branch May 2, 2024 09:30
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants