Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors theming app - part 4 #45146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+87 −238

refactor: Improves readability mainly by utilizing PHP8's constructor…

407e780
Select commit
Loading
Failed to load commit list.
Open

Refactors theming app - part 4 #45146

refactor: Improves readability mainly by utilizing PHP8's constructor…
407e780
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Psalm succeeded May 2, 2024 in 7s

10 new alerts

New alerts in code changed by this pull request

  • 10 notes

See annotations below for details.

View all branch alerts.

Annotations

Check notice on line 45 in apps/theming/lib/IconBuilder.php

See this annotation in the file changed.

Code scanning / Psalm

MissingParamType Note

Parameter $app has no provided type

Check notice on line 88 in apps/theming/lib/IconBuilder.php

See this annotation in the file changed.

Code scanning / Psalm

MissingParamType Note

Parameter $app has no provided type

Check notice on line 111 in apps/theming/lib/IconBuilder.php

See this annotation in the file changed.

Code scanning / Psalm

MissingParamType Note

Parameter $app has no provided type

Check notice on line 111 in apps/theming/lib/IconBuilder.php

See this annotation in the file changed.

Code scanning / Psalm

MissingParamType Note

Parameter $size has no provided type

Check notice on line 206 in apps/theming/lib/IconBuilder.php

See this annotation in the file changed.

Code scanning / Psalm

MissingParamType Note

Parameter $app has no provided type

Check notice on line 206 in apps/theming/lib/IconBuilder.php

See this annotation in the file changed.

Code scanning / Psalm

MissingParamType Note

Parameter $image has no provided type

Check notice on line 130 in apps/theming/lib/ThemingDefaults.php

See this annotation in the file changed.

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\IConfig::getAppValue has been marked as deprecated

Check notice on line 134 in apps/theming/lib/ThemingDefaults.php

See this annotation in the file changed.

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\IConfig::getAppValue has been marked as deprecated

Check notice on line 138 in apps/theming/lib/ThemingDefaults.php

See this annotation in the file changed.

Code scanning / Psalm

DeprecatedMethod Note

The method OCP\IConfig::getAppValue has been marked as deprecated

Check notice on line 195 in apps/theming/lib/Util.php

See this annotation in the file changed.

Code scanning / Psalm

MissingParamType Note

Parameter $color has no provided type