feat(log): Allow to combine log.conditions to only log (app&user) #45277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
reviewed
May 13, 2024
come-nc
reviewed
May 13, 2024
| * | ||
| * Defaults to an empty array. | ||
| */ | ||
| 'log.condition' => [ | ||
| 'shared_secret' => '57b58edb6637fe3059b3595cf9c41b9', | ||
| 'users' => ['sample-user'], | ||
| 'apps' => ['files'], | ||
| 'matches' => [ |
There was a problem hiding this comment.
Suggested change
| 'matches' => [ | |
| 'and' => [ |
Or is that too nerdy?
There was a problem hiding this comment.
Suggested change
| 'matches' => [ | |
| 'allof' => [ |
maybe?
There was a problem hiding this comment.
I had that at some point all ready, but my mind couldn't settle if it's allof or anyof and then I wondered if it's more understandable for people
come-nc
reviewed
May 13, 2024
miaulalala
requested changes
May 14, 2024
miaulalala
approved these changes
May 16, 2024
nickvergessen
force-pushed
the
techdebt/noid/log-condition-v2
branch
from
c83e80c to
af25b5a
Compare
Merged
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
techdebt/noid/log-condition-v2
branch
from
af25b5a to
710a69b
Compare
AndyScherzinger
approved these changes
Jul 30, 2024
come-nc
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improve log conditioning to allow only debug logging entries for user & app, dedicated log level for each condition and "log message contains" additionally.
Checklist