Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] 44032 fix show new shares without refresh #45303

Merged
merged 3 commits into from
Jun 13, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 14, 2024

Backport of #44464

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from artonge, susnux and nfebe May 14, 2024 10:13
@backportbot backportbot bot added this to the Nextcloud 28.0.6 milestone May 14, 2024
@solracsf solracsf changed the title [stable28] [stable27] 44032 fix show new shares without refresh [stable28] 44032 fix show new shares without refresh May 14, 2024
@nfebe nfebe marked this pull request as ready for review May 16, 2024 10:04
@nfebe nfebe force-pushed the backport/44464/stable28 branch from 350e159 to 7e01062 Compare May 16, 2024 10:08
@nfebe
Copy link
Contributor

nfebe commented May 16, 2024

/compile

@skjnldsv skjnldsv mentioned this pull request May 22, 2024
30 tasks
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 7, 2024
@blizzz blizzz mentioned this pull request Jun 11, 2024
6 tasks
@nfebe nfebe force-pushed the backport/44464/stable28 branch from 7e01062 to d1b2b3c Compare June 12, 2024 15:32
@nfebe nfebe force-pushed the backport/44464/stable28 branch from d1b2b3c to 0e55398 Compare June 12, 2024 22:08
@nfebe nfebe enabled auto-merge June 12, 2024 22:16
These changes fixes the issue of having the refresh the UI after share creation, as the share is not
immediately removed from the UI list.

Important changes

- The basis of checking wether a password/expire date is no longer based on config values alone
because the config is not expected in a share creation circle. Hence we check the configs and check
if the share object (this.share) has the expected values set. This way, once the required properties
are set, code control does not enter the block meant to handle the setting of required properties
unneccessarily.

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the backport/44464/stable28 branch from 0e55398 to 013768a Compare June 12, 2024 23:20
@nfebe
Copy link
Contributor

nfebe commented Jun 12, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe merged commit 857b208 into stable28 Jun 13, 2024
44 of 45 checks passed
@nfebe nfebe deleted the backport/44464/stable28 branch June 13, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants