Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] Avoid updating the same oc_authtoken row twice #45348

Merged
merged 3 commits into from
Jun 6, 2024
Merged

[stable29] Avoid updating the same oc_authtoken row twice #45348

merged 3 commits into from
Jun 6, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 16, 2024 •
edited by kesselb
Loading

@backportbot backportbot bot added this to the Nextcloud 29.0.1 milestone May 16, 2024
ChristophWurst
ChristophWurst previously requested changes May 16, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#45026 (comment)

@ChristophWurst ChristophWurst marked this pull request as draft May 21, 2024 06:17
@ChristophWurst ChristophWurst added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 21, 2024
@kesselb
Copy link
Contributor

kesselb commented May 29, 2024

Cherry picked bcc02a3

@kesselb kesselb force-pushed the backport/45026/stable29 branch from 0002db5 to a8577a7 Compare May 29, 2024 10:11
@kesselb kesselb marked this pull request as ready for review May 31, 2024 11:57
@kesselb kesselb force-pushed the backport/45026/stable29 branch from a8577a7 to 609734c Compare May 31, 2024 11:57
juliusknorr and others added 3 commits June 6, 2024 14:39
@juliusknorr @kesselb
docs: Update token_auth_activity_update default value to match implem…
9058428 
…entation

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr @kesselb
fix: Always set last activity if we update the row of an authtoken an…
c647f89 
…yways

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@ChristophWurst @kesselb
fix(auth): Update authtoken activity selectively
ce339b3 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@kesselb kesselb force-pushed the backport/45026/stable29 branch from 609734c to ce339b3 Compare June 6, 2024 12:39
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 6, 2024
@AndyScherzinger AndyScherzinger merged commit e49aaaf into stable29 Jun 6, 2024
167 of 168 checks passed
@AndyScherzinger AndyScherzinger deleted the backport/45026/stable29 branch June 6, 2024 16:01
@blizzz blizzz mentioned this pull request Jun 11, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@Altahrim Altahrim Altahrim approved these changes

@ChristophWurst ChristophWurst ChristophWurst left review comments

@joshtrichards joshtrichards Awaiting requested review from joshtrichards

Assignees

@juliusknorr juliusknorr

Labels
3. to review Waiting for reviews enhancement feature: authentication performance 🚀
Projects
None yet
Milestone
Nextcloud 29.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@kesselb @ChristophWurst @Altahrim @juliusknorr @AndyScherzinger