-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files_versions): renaming file version when its not a string #45958
Conversation
@sanskar-soni-9 I think one e2e test is legitimately failing. Can you take a look at it? :) |
@artonge Its failing when undefined, oops... 😅 I fixed it now in original PR |
@artonge original PR is merged and I updated the fix and rebased with current master in my branch so do I need to create new PR? |
Can you try to update this PR? Not sure whether you have the permission. |
Signed-off-by: Sanskar Soni <sanskarsoni300@gmail.com>
3409c21
to
2aecc52
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
/backport to stable29 |
/backport to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/45958/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2aecc523 efe4e047
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45958/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Needed to run Cypress CI
cc @sanskar-soni-9