perf: delay getting (sub)admin status for user in the security middleware untill we need it #46021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
nickvergessen,
a team,
ArtificialOwl,
yemkareems and
sorbaugh
and removed request for
a team
nickvergessen
approved these changes
Jun 21, 2024
yemkareems
approved these changes
Jun 24, 2024
|
Merged
…ware untill we need it Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
middleware-delay-admin
branch
from
d86fd20 to
8b60df1
Compare
susnux
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to check if we're admin for non-admin routes.
Should save 1 or 2 queries for most routes