feat: Store user which has downloaded file in activity feed

[Koc]

Summary

I've added information about user which downloaded file via public link (if this user was logged in)

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[Koc]

@kesselb can you run pipeline for PR?

[Koc]

mates, seems like some test failures are unrelated to my changes. How can we fix them?

• performance: Errors during submodule fetch: 3rdparty
• cypress tests

[kesselb]

Ignore performance and cypress for now.

[Koc]

@kesselb all green 🟢, except performance and cypress

[artonge]

Rebased

[Koc]

@artonge so, let's merge then?

[artonge]

@Koc sure, I created a local copy of your PR here: #46533
This is to have the result of all the CI steps.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[skjnldsv]

Tests were successful in #46533
Can be merged for 31

[Koc]

sad that we can't include it into 30 😿

[skjnldsv]

To be fair, I think this also requires some discussion. Because we have no display on the public sharing pages, to tell the user they are logged in, I think this creates a fake feeling of privacy. You might want to open a link and not be tracked as an existing user.

[Koc]

@skjnldsv to be honest I don't see any problem here because functionality named "Shared link" and not "Anonymous link". Also I can add some kind of warning message for logged in users that we will store his username during download. WDYT?

[sorbaugh]

@Koc does this also work with internal links?

[Koc]

@sorbaugh good question. No, in this case there are no any activity stored at all. Url looks like http://localhost/remote.php/dav/files/user/308986224.jpg and it seems like we're not entering into ShareController at all.

Maybe we can store activity by modifying \OCA\DAV\Connector\Sabre\FilesPlugin::httpGet in separate PR, WDYT?

BTW I've rebased PR but there are still conflicts in the ShareControllerTest 😕

[kesselb]

@Koc conflicts 😨

[Koc]

@kesselb I know 😃

Fixed, BTW