fix: Make account menu follow the design (use nextcloud-vue components)

[susnux]

• Resolves: [Bug]: User menu in the header doesn't follow design changes  #46460

Summary

Make the account menu use NcListItem to automatically follow the new design rules.

Screenshots

before	after

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[jancborchardt]

Thanks @susnux! :) So it does look a bit strange, some detail points:

• The icons seem to have grown, or is this an illusion?
• Top padding above "admin" username is less than on the left, should be equidistant
• The right margin (or padding) is very little, visible at "Appearance and accessibility"

[susnux]

Thanks @susnux! :) So it does look a bit strange, some detail points:

* [ ]  The icons seem to have grown, or is this an illusion?

I made them 20px but now reverted to 16px.

* [ ]  Top padding above "admin" username is less than on the left, should be equidistant

Was already the same as inline padding (4px grid baseline), you see this if the entry is active and get primary coloring. but adjusted a bit.

* [ ]  The right margin (or padding) is very little, visible at "Appearance and accessibility"

Increased both to 8px (2* grid baseline).

I personally think there is too much space between icon and text, but this comes from missing adjustments from shrinking clickable area / padding in the NcListItem component.

[marcoambrosini]

@susnux why not action menu for this?

[susnux]

why not action menu for this?

@marcoambrosini what do you mean? Naming? Or using NcActions?
If you mean NcActions, than we can not use that because they have more complex render logic and do not allow arbitrary content, but this menu does allow apps to register custom entries which is not possible with NcActions.

[susnux]

@marcoambrosini @jancborchardt what do you think of the changes now? Can we go with it or should I adjust it?

Changes implemented