Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(caldav): allow renaming of birthday calendars #47332

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Aug 19, 2024

Summary

Default Birthday Calendars use a translation to show the correct default name for all languages.

Only use the translation if a user hasn't renamed their calendar.

Checklist

@miaulalala miaulalala added the 3. to review Waiting for reviews label Aug 19, 2024
@miaulalala miaulalala self-assigned this Aug 19, 2024
@miaulalala
Copy link
Contributor Author

/backport to stable30

@miaulalala
Copy link
Contributor Author

/backport to stable29

@miaulalala
Copy link
Contributor Author

/backport to stable28

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the fix/allow-renaming-of-birthday-calendars branch from 4d7ccb3 to 5bbc23a Compare August 20, 2024 08:17
@miaulalala miaulalala enabled auto-merge August 20, 2024 08:41
@miaulalala miaulalala merged commit 560282a into master Aug 20, 2024
171 checks passed
@miaulalala miaulalala deleted the fix/allow-renaming-of-birthday-calendars branch August 20, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

Unable to rename Contact birthday calendar
3 participants