Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(migration): Add missing migration attributes #47419

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

nickvergessen
Copy link
Member

Was missing from community PR #47253

Checklist

@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Aug 22, 2024
@nickvergessen nickvergessen added this to the Nextcloud 31 milestone Aug 22, 2024
@nickvergessen nickvergessen self-assigned this Aug 22, 2024
@nickvergessen nickvergessen requested a review from st3iny August 22, 2024 10:20
@nickvergessen
Copy link
Member Author

/backport to stable30

@come-nc
Copy link
Contributor

come-nc commented Aug 22, 2024

ref: #46476
@nickvergessen Why only this migrations? None of the core migrations have the attributes it seems.

@nickvergessen
Copy link
Member Author

None of the core migrations have the attributes it seems.

30+ migrations are supposed to have it.

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/add-missing-attribute branch from 246fe00 to 4b6490e Compare August 22, 2024 18:59
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyScherzinger
Copy link
Member

@come-nc they actually should have them. At least @ArtificialOwl did add them to v30 some time ago. But if there are still some missing, we should have them added 👍

@kesselb kesselb merged commit d78bfb7 into master Aug 22, 2024
171 checks passed
@kesselb kesselb deleted the bugfix/noid/add-missing-attribute branch August 22, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants