Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(transfer-ownership): Correctly react to encrypted files #47519

Merged
merged 2 commits into from
Sep 5, 2024
Merged

feat(transfer-ownership): Correctly react to encrypted files #47519

merged 2 commits into from
Sep 5, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Aug 27, 2024 •
edited by solracsf
Loading

  • Resolves: #

Summary

  1. For E2EE encrypted files, we abort the transfer.
  2. For SSE encrypted files, we abort only if not using master key.
  3. Also fixed the check for when the path to a single file is used.

Checklist

@come-nc come-nc added bug 3. to review Waiting for reviews labels Aug 27, 2024
@come-nc come-nc added this to the Nextcloud 31 milestone Aug 27, 2024
@come-nc come-nc self-assigned this Aug 27, 2024
@come-nc
Copy link
Contributor Author

come-nc commented Aug 27, 2024

/backport to stable30

@come-nc
Copy link
Contributor Author

come-nc commented Aug 27, 2024

/backport to stable29

@come-nc
Copy link
Contributor Author

come-nc commented Aug 27, 2024

/backport to stable28

@come-nc come-nc requested review from artonge, a team, skjnldsv and yemkareems and removed request for a team August 27, 2024 11:07
ChristophWurst
ChristophWurst approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not my area of expertise but the changes make sense and look good

@come-nc come-nc requested a review from artonge September 3, 2024 07:47
@come-nc
feat(transfer-ownership): Correctly react to encrypted files
d92bf38 
For E2EE encrypted files, we abort the transfer.
For SSE encrypted files, we abort only if not using master key.
Also fixed the check for when the path to a single file is used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
fix(transfer-ownership): Improve comments according to code review
0555900 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/transfer-ownership-encrypted-files branch from 5f73f3c to 0555900 Compare September 5, 2024 12:44
@sorbaugh sorbaugh merged commit 3f79566 into master Sep 5, 2024
167 of 174 checks passed
@sorbaugh sorbaugh deleted the fix/transfer-ownership-encrypted-files branch September 5, 2024 15:58
This was referenced Sep 5, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
4 participants
@come-nc @ChristophWurst @artonge @sorbaugh