Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-enable content-length header via htaccess #47598

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Aug 29, 2024

Close #47017
Close nextcloud/all-in-one#5119

# Apache disabled the sending of the server-side content-length header 
# in their 2.4.59 patch updated which breaks some use-cases in Nextcloud.
# Setting ap_trust_cgilike_cl allows to bring back the usual behaviour.
# See https://bz.apache.org/bugzilla/show_bug.cgi?id=68973

@szaimen
Copy link
Contributor Author

szaimen commented Aug 29, 2024

/backport to stable30

@szaimen
Copy link
Contributor Author

szaimen commented Aug 29, 2024

/backport to stable29

@szaimen
Copy link
Contributor Author

szaimen commented Aug 29, 2024

/backport to stable28

@szaimen szaimen added this to the Nextcloud 31 milestone Aug 29, 2024
@szaimen szaimen requested review from artonge, skjnldsv, a team and nickvergessen August 29, 2024 07:57
.htaccess Outdated Show resolved Hide resolved
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen force-pushed the enh/47017/re-enable-content-length-header branch from f05b774 to 3739fb7 Compare August 29, 2024 09:51
@szaimen szaimen changed the title bug: re-enable content-length header via htaccess fix: re-enable content-length header via htaccess Aug 29, 2024
@sorbaugh sorbaugh merged commit 6e4e9cf into master Aug 29, 2024
116 checks passed
@sorbaugh sorbaugh deleted the enh/47017/re-enable-content-length-header branch August 29, 2024 10:53

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

@provokateurin
Copy link
Member

@skjnldsv do you know what's going on with the backport bot? The diff of this PR is clearly not the cause

@szaimen

This comment was marked as resolved.

This comment was marked as resolved.

@skjnldsv

This comment was marked as resolved.

This comment was marked as resolved.

@skjnldsv
Copy link
Member

/backport to stable30

Copy link

backportbot bot commented Aug 30, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/47598/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3739fb7a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47598/stable30

Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout:
dist/3794-3794.js.map.license
dist/4546-4546.js.map.license
dist/4696-4696.js.map.license
dist/5643-5643.js.map.license
dist/583-583.js.map.license
dist/9972-9972.js.map.license
Please commit your changes or stash them before you switch branches.
Aborting


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv
Copy link
Member

/backport to stable30

Copy link

backportbot bot commented Aug 30, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/47598/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3739fb7a

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47598/stable30

Error: Failed to clone repository: Failed to checkout branches: error: Your local changes to the following files would be overwritten by checkout:
dist/3794-3794.js.map.license
dist/4546-4546.js.map.license
dist/4696-4696.js.map.license
dist/5643-5643.js.map.license
dist/583-583.js.map.license
dist/9972-9972.js.map.license
Please commit your changes or stash them before you switch branches.
Aborting


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@skjnldsv
Copy link
Member

/backport to stable30

@szaimen
Copy link
Contributor Author

szaimen commented Aug 30, 2024

/backport to stable29

@szaimen
Copy link
Contributor Author

szaimen commented Aug 30, 2024

/backport to stable28

@solracsf
Copy link
Member

solracsf commented Aug 30, 2024

Sorry for the late review.
This has been removed by apache for security reasons.
I don't know if enabling it server wide (and not targeting .php files only) could be a security issue or not.

See this for more details: https://www.suse.com/fr-fr/support/kb/doc/?id=000021486

@provokateurin
Copy link
Member

This was already discussed in the company's security chat and reviews and approvals were based on that discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: please send content-length header in http stream
5 participants