-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(caldav, carddav): also allow unsharing of circle shares #47737
Conversation
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
LGTM 👍 Commit message needs an update |
341ee6b
to
3355b20
Compare
Signed-off-by: Anna Larch <anna@nextcloud.com>
3355b20
to
17ef20c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but didn't test.
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/47737/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17ef20c5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47737/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/47737/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 17ef20c5
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47737/stable29 Error: Failed to push branch backport/47737/stable29: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
Unsharing a group share should also be possible for Circle group shares
TODO
Checklist