Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): undefined sidebar #47738

Merged
merged 2 commits into from
Sep 4, 2024
Merged

fix(files): undefined sidebar #47738

merged 2 commits into from
Sep 4, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 4, 2024

If file doesn't exist, the Sidebar is not mounted, so refs.sidebar is undefined

<NcAppSidebar v-if="file"
ref="sidebar"

Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: files feature: file sidebar Related to the file sidebar component labels Sep 4, 2024
@skjnldsv skjnldsv requested review from blizzz and a team September 4, 2024 12:12
@skjnldsv skjnldsv self-assigned this Sep 4, 2024
@skjnldsv skjnldsv requested review from susnux, Pytal and szaimen and removed request for a team September 4, 2024 12:12
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2024

/backport to stable30

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2024

/backport to stable29

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2024

/backport to stable28

@susnux
Copy link
Contributor

susnux commented Sep 4, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 4, 2024
@skjnldsv skjnldsv merged commit 2d2a510 into master Sep 4, 2024
116 checks passed
@skjnldsv skjnldsv deleted the fix/sidebar-undefined branch September 4, 2024 14:50
@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 4, 2024

/backport to stable29

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug feature: file sidebar Related to the file sidebar component feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants