Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Replace conflicting tags in xml_exception template #47805

Merged
merged 1 commit into from
Sep 9, 2024
Merged

fix: Replace conflicting tags in xml_exception template #47805

merged 1 commit into from
Sep 9, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 6, 2024

Summary

The <?xml tag is interpreted as PHP short tags, so this causes errors. Instead just print that part of the template.

Checklist

@susnux susnux added bug 3. to review Waiting for reviews regression labels Sep 6, 2024
@susnux susnux added this to the Nextcloud 31 milestone Sep 6, 2024
@susnux susnux requested review from artonge, a team, ArtificialOwl and sorbaugh and removed request for a team September 6, 2024 14:51
@susnux susnux force-pushed the fix/xml-exception-template branch from 6a738b1 to e5745d7 Compare September 6, 2024 15:14
@susnux
Copy link
Contributor Author

susnux commented Sep 7, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Sep 7, 2024

/backport to stable30

@susnux susnux mentioned this pull request Sep 7, 2024
Merged
2 tasks
Antreesy
Antreesy approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just stumbled on it, when tried to upload files via Talk (failed on PROPFIND request)

Tested, works with this change

@susnux
fix: Replace conflicting tags in xml_exception template
6198138 
The `<?xml` tag is interpreted as PHP short tags, so this causes errors.
Instead just print that part of the template.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/xml-exception-template branch from 923850b to 6198138 Compare September 9, 2024 11:27
@susnux susnux enabled auto-merge September 9, 2024 11:27
@susnux susnux merged commit 00712c2 into master Sep 9, 2024
174 checks passed
@susnux susnux deleted the fix/xml-exception-template branch September 9, 2024 11:44
This was referenced Sep 9, 2024
Merged
Merged
@joshtrichards joshtrichards mentioned this pull request Oct 13, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@provokateurin provokateurin provokateurin approved these changes

@artonge artonge artonge approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug regression
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @artonge @provokateurin @Antreesy