Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip future shipped apps from updatenotification check #48375

Conversation

nickvergessen
Copy link
Member

Checklist

…n 29+

Signed-off-by: Joas Schilling <coding@schilljs.com>
… as shipped in 30+

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

/backport to stable30

@nickvergessen
Copy link
Member Author

/backport to stable29

@nickvergessen
Copy link
Member Author

/backport aea325f to stable28

@nickvergessen nickvergessen merged commit dd53a94 into master Sep 26, 2024
173 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/skip-future-shipped-apps-from-updatenotification-check branch September 26, 2024 13:23
Comment on lines 39 to +44
'bruteforcesettings' => 25,
'suspicious_login' => 25,
'twofactor_totp' => 25,
'files_downloadlimit' => 29,
'twofactor_nextcloud_notification' => 30,
'app_api' => 30,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'bruteforcesettings' => 25,
'suspicious_login' => 25,
'twofactor_totp' => 25,
'files_downloadlimit' => 29,
'twofactor_nextcloud_notification' => 30,
'app_api' => 30,
'app_api' => 30,
'bruteforcesettings' => 25,
'circles' => 22,
'files_downloadlimit' => 29,
'suspicious_login' => 25,
'twofactor_nextcloud_notification' => 30,
'twofactor_totp' => 25,

+circles? (though I guess it may not matter at this point)
sort maybe too since we're here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't help to add things from the past which we don't release anymore.
Also it's sorted by version added atm, just got mixed as app_api is not 31 bug 30 and I amended the fix

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its easier to compare with the packaging script this way 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants