Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly count disabled users for subadmins #48437

Merged
merged 1 commit into from
Sep 30, 2024
Merged

fix: correctly count disabled users for subadmins #48437

merged 1 commit into from
Sep 30, 2024

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Sep 28, 2024 •
edited
Loading

  • Resolves: #

Summary

countDisabledUsersOfGroups expects array of groups ids, groups name were given instead. Due to this, users count might be faulty (usually name === id, but could be changed)

Before After
image image

Checklist

@Antreesy
fix: correctly count disabled users for subadmins
2b2b4e9 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added this to the Nextcloud 31 milestone Sep 28, 2024
@Antreesy Antreesy self-assigned this Sep 28, 2024
@Antreesy Antreesy marked this pull request as ready for review September 30, 2024 07:26
provokateurin
provokateurin reviewed Sep 30, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a test for it?

@Antreesy
Copy link
Contributor Author

Could you also add a test for it?

Feel free to help. I see nothing in apps/settings/tests/Controller/UsersControllerTest.php that i could add/modify with my PHP-knowledge

@provokateurin provokateurin merged commit 54cdd42 into master Sep 30, 2024
177 checks passed
@provokateurin provokateurin deleted the fix/noid/count-disabled-correct branch September 30, 2024 09:59
@Antreesy
Copy link
Contributor Author

/backport to stable30

@Antreesy
Copy link
Contributor Author

/backport to stable29

@Antreesy
Copy link
Contributor Author

/backport to stable28

@backportbot backportbot bot mentioned this pull request Sep 30, 2024
Merged
This was referenced Sep 30, 2024
Merged
Merged
@Antreesy Antreesy mentioned this pull request Oct 2, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees

@Antreesy Antreesy

Labels
3. to review Waiting for reviews bug feature: users and groups
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@Antreesy @nickvergessen @provokateurin