fix: Return correct list of managers for a user #48538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
approved these changes
Oct 3, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Pytal
force-pushed
the
fix/get-managers-as-subadmin
branch
from
2d200d1 to
2ecf322
Compare
Pytal
force-pushed
the
fix/get-managers-as-subadmin
branch
from
2ecf322 to
06acad5
Compare
come-nc
approved these changes
Oct 7, 2024
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/get-managers-as-subadmin
branch
from
06acad5 to
f162b7a
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/get-managers-as-subadmin
branch
from
f162b7a to
1dcdc87
Compare
|
/backport to stable30 |
Pytal
force-pushed
the
fix/get-managers-as-subadmin
branch
3 times, most recently
from
c693156 to
2b6dbaf
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
fix/get-managers-as-subadmin
branch
from
2b6dbaf to
96035d2
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #47642
Subadmins may not have access to certain users so we only return the uids for users that are accessible.
Checklist