Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] chore: Replace Twitter & Diaspora links and text #48620

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 8, 2024

Backport of #48520

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Remove all the empty commits

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot added the 3. to review Waiting for reviews label Oct 8, 2024
@backportbot backportbot bot added this to the Nextcloud 30.0.1 milestone Oct 8, 2024
@susnux susnux force-pushed the backport/48520/stable30 branch from 6379db8 to 0366b61 Compare October 8, 2024 19:10
@susnux susnux marked this pull request as ready for review October 8, 2024 19:10
nfebe and others added 2 commits October 9, 2024 15:34
- Use Twitters new name "X"
- Remove Diaspora social and include Mastodon instead

Resolves : #48409

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
…han inline SVGs

* Use correct facebook icon provided by Meta
  The legal terms require to exactly use the facebook logo as provided by Meta.
* Add correct X logo as provided by X Corp.
* Use social media icons from core rather than inline SVGs
* Make copy logic more resilient and use Typescript
* Add aria label to include the `X` in `X (formerly Twitter)` button.
* Use valid mastodon URL for sharing

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the backport/48520/stable30 branch from 0366b61 to 1d3bc3f Compare October 9, 2024 13:34
@susnux
Copy link
Contributor

susnux commented Oct 9, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This was referenced Oct 10, 2024
@Altahrim Altahrim mentioned this pull request Oct 30, 2024
2 tasks
@Altahrim Altahrim enabled auto-merge October 30, 2024 08:29
@Altahrim Altahrim merged commit 4ee7630 into stable30 Oct 30, 2024
113 checks passed
@Altahrim Altahrim deleted the backport/48520/stable30 branch October 30, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants