Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect permissions when copying shared files #48769

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix incorrect permissions when copying shared files #48769

wants to merge 3 commits into from
+34 −1

Conversation

icewind1991
Copy link
Member

  • Save the original permissions of shared files as scan_permissions
  • Use scan_permissions as the target permissions when doing copyFromCache

To test:

  • setup instance with s3
  • Share F1 from U1 to U2
  • As U2 copy F1 to another folder
  • Check that the copied file has delete permissions

@icewind1991
fix: store unmaked source permissions as scan_permissions when loadin…
abb664c 
…g share cache items

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: use scan_permissions when copying cache items
20e08af 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
test: add test for permissions of copied share
a0000c5 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Oct 17, 2024
@icewind1991 icewind1991 added this to the Nextcloud 31 milestone Oct 17, 2024
@icewind1991 icewind1991 requested review from a team, Altahrim, provokateurin and sorbaugh and removed request for a team October 17, 2024 16:31
@icewind1991
Copy link
Member Author

Fixes #46248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
2 participants
@icewind1991 @provokateurin