[wip] Support sharding migration #48795
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support migrating existing instances to sharding.
Enabled by setting the sharding configuration and setting the
from_shard_keyandfrom_primaryto the sharding configuration with the next storage/file id (so the first storage/file that will be created after sharding is configured).Any files on the existing storages will still go to the main db, only newly created storages will be sharded.
Things seem to work, but in some cases, the "File entry could not be inserted but could also not be selected with getId() in order to perform an update. Please try again." error gets thrown. (creating a new user is the most reliable way I found).
While things seem to work otherwise, I suspect that this issue is a sign of a bigger connection handling issue.