fix(files_sharing): federated shares avatar #48887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
bug
design
skjnldsv
requested review from
szaimen and
sorbaugh
and removed request for
a team
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/federated-users
branch
from
1f9ca94 to
a1ffa84
Compare
|
Added tests |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
2 tasks
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nfebe
approved these changes
Oct 25, 2024
provokateurin
approved these changes
Oct 28, 2024
susnux
approved these changes
Oct 28, 2024
skjnldsv
added
4. to release
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We fallback to
?guestFallback=trueonly for the normal AvatarControllerIf we already know this is a guest user, we do not need to fallback at all, we can go straight to the GuestAvatarController